Underlight Discord Chat: http://discord.underlight.com/
Production Server: Online (Version 3.1.15)
Player Test Realm Server: Offline (Version 3.1.15)

chat test ptr

Locked
User avatar
fancypearl
PTR Tester (Rank 3)
Posts: 119
Joined: Sun Sep 28, 2014 2:29 am
Character Name(s): Palimpsest
Location: Eugene, Oregon

chat test ptr

Post by fancypearl »

Patch 3.1.9

- Legacy chat re-introduced into the clients - Credit goes to OpenUL project

(tested alone for now, gui seems to work, chat shows in chat.)

Testing normal chat function.
chat works, emote works, shout works, bug works, report works, rp works, whispering to emphant works.

classic chat,
chat works, emote works, shout works, bug works, report works, rp works,whispering to emphant works.
User avatar
fancypearl
PTR Tester (Rank 3)
Posts: 119
Joined: Sun Sep 28, 2014 2:29 am
Character Name(s): Palimpsest
Location: Eugene, Oregon

Re: chat test ptr

Post by fancypearl »

verified with gm client, whispered back and forth confirmed working, with chat, shout, emote
User avatar
Koi-JorKyrin
System Administrator
Posts: 266
Joined: Sat Feb 01, 2014 6:33 pm

Re: chat test ptr

Post by Koi-JorKyrin »

Since this also involved modifications around the window positioning code on both resolutions, I tested it in 800x600. The chat box placement looks correct and all chat functions are working. Did the same with pmare client. All normal preset chat maren features work as expected. One thing to note is I also had to add the classicChatPos to the pmare build otherwise it would fail to build.

I let the OpenUL folks know that this is what I had to do to get it to compile. They may have additional input on this to change. Someone will probably have to post that as an issue as I just realized it was posted on a closed merge request on OpenUL side:
https://github.com/openunderlight/ULClient/pull/5


cChat.cpp: Added after #else on line 66

Code: Select all

// position for chat display area - no ads 
#ifndef PMARE
const struct window_pos_t classicChatPos[MAX_RESOLUTIONS] =
{ { 0, 300, 480, 180 },{ 0, 375, 600, 225 },{ 0, 480, 768, 288 } };

const struct window_pos_t chatPos[MAX_RESOLUTIONS] = 
{ { 0, 300, 480, 155 }, { 0, 375, 600, 194 }, { 0, 480, 768, 253 } };

const struct window_pos_t entryPos[MAX_RESOLUTIONS] =
{ { 0, 455, 480, 25 }, { 0, 570, 600, 35 }, { 0, 733, 768, 40 } };
#else
const struct window_pos_t classicChatPos[MAX_RESOLUTIONS] =
{ { 0, 300, 480, 180 },{ 0, 375, 600, 225 },{ 0, 480, 768, 288 } };

const struct window_pos_t chatPos[MAX_RESOLUTIONS] =
{ { 0, 300, 480, 180 },{ 0, 375, 600, 225 },{ 0, 480, 768, 288 } };
#endif

While the option for classic chat checkbox is not present on pmare login screen and does not require it, the build process itself certainly needed the above L66 section for pmare to build successfully. I did notice some strange pmare chat window positioning as I drag the window around and attempt to maren chat at each window location. Depending where I drag the pame game window, the chat box is either on the top of the view port, or other times it is at the bottom. This happens on production side as well, so I am not concerned with it, or believe it to be due to this L66 addition.

Anyways the pmare chat box issue isn't crucial to be fixed now, but needed to point this out.

As always, thank you for the help testing fancypearl !
Koi - Jor'Kyrin
System Administrator
KoiWare, LLC
Tary
Dreamer
Posts: 265
Joined: Mon Apr 28, 2014 9:09 am

Re: chat test ptr

Post by Tary »

Thanks, sidas pointed out the pmare issue the other day. Will merge into master
Locked